Do not include windows.h in statemap.hpp #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
reviewed
Jan 23, 2025
| @@ -52,7 +52,6 @@ | |||
| #endif // SMC_NO_EXCEPTIONS | |||
| #include <cstdio> | |||
| #elif defined(WIN32) | |||
| #include <windows.h> | |||
There was a problem hiding this comment.
I know your point is only to fix the Windows problem, but I kind of feel like this nest of ifdefs can be replaced by:
#if defined(SMC_NO_EXCEPTIONS)
#include <cassert>
#include <cstdio>
#else
#include <cstring>
#include <stdexcept>
#endif
What do you think?
There was a problem hiding this comment.
Good point, I did not actually check the code context, I implemented the suggested solution in 0a2720b .
clalancette
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
windows.hin a public header may screw up any call tostd::min,std::maxor any enum calledERROR(that are quite frequent). Apparently this specific include is unused (see #46) so we can safely remove it.